summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJean-François Milants <jf@codingfield.com>2021-11-14 19:32:25 (GMT)
committerJean-François Milants <jf@codingfield.com>2021-11-14 19:32:25 (GMT)
commit9671a8451fc0bc49fcd06521906d8be53959a74f (patch)
treef198b2a0fd99f00278316496bf263e85e5338a28
parenta57fda6ba4a29866083a1254ffdf92939d00e182 (diff)
Fix unresponsive touch panel after update to 1.7 : don't care if device ids are not the ones we expected (until we know more about these communication and IDs issues).
-rw-r--r--CMakeLists.txt2
-rw-r--r--src/drivers/Cst816s.cpp16
2 files changed, 6 insertions, 12 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 63257ff..b588066 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.10)
-project(pinetime VERSION 1.7.0 LANGUAGES C CXX ASM)
+project(pinetime VERSION 1.7.1 LANGUAGES C CXX ASM)
set(CMAKE_C_STANDARD 99)
set(CMAKE_CXX_STANDARD 14)
diff --git a/src/drivers/Cst816s.cpp b/src/drivers/Cst816s.cpp
index 4aac19f..bf51a8b 100644
--- a/src/drivers/Cst816s.cpp
+++ b/src/drivers/Cst816s.cpp
@@ -32,17 +32,11 @@ bool Cst816S::Init() {
twiMaster.Read(twiAddress, 0xa7, &dummy, 1);
vTaskDelay(5);
- static constexpr uint8_t maxRetries = 3;
- bool isDeviceOk;
- uint8_t retries = 0;
- do {
- isDeviceOk = CheckDeviceIds();
- retries++;
- } while (!isDeviceOk && retries < maxRetries);
-
- if (!isDeviceOk) {
- return false;
- }
+ // TODO This function check that the device IDs from the controller are equal to the ones
+ // we expect. However, it seems to return false positive (probably in case of communication issue).
+ // Also, it seems that some users have pinetimes that works correctly but that report different device IDs
+ // Until we know more about this, we'll just read the IDs but not take any action in case they are not 'valid'
+ CheckDeviceIds();
/*
[2] EnConLR - Continuous operation can slide around