<feed xmlns='http://www.w3.org/2005/Atom'>
<title>infinitime.git/src/displayapp/screens, branch develop</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.
</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/'/>
<entry>
<title>Analog24 watchface</title>
<updated>2022-03-23T10:48:57Z</updated>
<author>
<name>Michele Bini</name>
<email>michele.bini@gmail.com</email>
</author>
<published>2022-03-23T10:48:57Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=a62b893469765923a113acdf85627ce39322880f'/>
<id>a62b893469765923a113acdf85627ce39322880f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1038 from NeroBurner/analog_local_variables</title>
<updated>2022-03-14T20:25:46Z</updated>
<author>
<name>JF</name>
<email>JF002@users.noreply.github.com</email>
</author>
<published>2022-03-14T20:25:46Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=1c4a56b05bf4fcd89d95a7c04e5a7a22f554f00c'/>
<id>1c4a56b05bf4fcd89d95a7c04e5a7a22f554f00c</id>
<content type='text'>
WatchFaceAnalog: local date/time variables</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
WatchFaceAnalog: local date/time variables</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1033 from NeroBurner/music_override_warning</title>
<updated>2022-03-14T20:21:33Z</updated>
<author>
<name>JF</name>
<email>JF002@users.noreply.github.com</email>
</author>
<published>2022-03-14T20:21:33Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=5f2ce53877e3b8b43cf59a04b5c66e4845a18046'/>
<id>5f2ce53877e3b8b43cf59a04b5c66e4845a18046</id>
<content type='text'>
Music: fix warning about overridden function</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Music: fix warning about overridden function</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1034 from NeroBurner/twos_comparison_warning</title>
<updated>2022-03-14T20:21:11Z</updated>
<author>
<name>JF</name>
<email>JF002@users.noreply.github.com</email>
</author>
<published>2022-03-14T20:21:11Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=fc374562ddd81629bec2958ceceaa308debb27f2'/>
<id>fc374562ddd81629bec2958ceceaa308debb27f2</id>
<content type='text'>
Twos: fix warning about extra paranthesis</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Twos: fix warning about extra paranthesis</pre>
</div>
</content>
</entry>
<entry>
<title>WatchFaceAnalog: local date/time variables</title>
<updated>2022-03-14T20:00:07Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2022-03-14T19:33:14Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=1379b7902fca8628614af358bac7d546cc94efdc'/>
<id>1379b7902fca8628614af358bac7d546cc94efdc</id>
<content type='text'>
Use local date and time variables. No need to store them in the object.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Use local date and time variables. No need to store them in the object.
</pre>
</div>
</content>
</entry>
<entry>
<title>WatchFaceAnalog: const ref to dateTimeController</title>
<updated>2022-03-14T19:59:44Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2022-03-14T19:55:20Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=bebc072e78145af69aacb1c2c9549da8653b7b0c'/>
<id>bebc072e78145af69aacb1c2c9549da8653b7b0c</id>
<content type='text'>
The clock app only reads from the dateTimeController, never modifies it.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The clock app only reads from the dateTimeController, never modifies it.
</pre>
</div>
</content>
</entry>
<entry>
<title>Twos: fix warning about extra paranthesis</title>
<updated>2022-03-13T21:05:25Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2022-03-13T21:03:29Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=51716898aa00ea2d38dfe38d28a33b4ffbdf22ff'/>
<id>51716898aa00ea2d38dfe38d28a33b4ffbdf22ff</id>
<content type='text'>
We have a comparison like `if (( a == b ))`, which is a parenthesis too
much, which generates the following warning

```
InfiniTime/src/displayapp/screens/Twos.cpp:133:35: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
  if ((grid[newRow][newCol].value == grid[oldRow][oldCol].value)) {
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
InfiniTime/src/displayapp/screens/Twos.cpp:133:35: note: remove extraneous parentheses around the comparison to silence this warning
  if ((grid[newRow][newCol].value == grid[oldRow][oldCol].value)) {
      ~                           ^                            ~
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
We have a comparison like `if (( a == b ))`, which is a parenthesis too
much, which generates the following warning

```
InfiniTime/src/displayapp/screens/Twos.cpp:133:35: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
  if ((grid[newRow][newCol].value == grid[oldRow][oldCol].value)) {
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
InfiniTime/src/displayapp/screens/Twos.cpp:133:35: note: remove extraneous parentheses around the comparison to silence this warning
  if ((grid[newRow][newCol].value == grid[oldRow][oldCol].value)) {
      ~                           ^                            ~
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Music: fix warning about overridden function</title>
<updated>2022-03-13T20:58:53Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2022-03-13T20:58:53Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=0933d60b1627df18c5615c610b8e26a685901b44'/>
<id>0933d60b1627df18c5615c610b8e26a685901b44</id>
<content type='text'>
Clang warns on `OnTouchEvent()` function, which is overridden, but is
missing the `override` keyword

```
In file included from InfiniTime/src/displayapp/screens/Music.cpp:18:
InfiniTime/src/displayapp/screens/Music.h:43:14: warning: 'OnTouchEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        bool OnTouchEvent(TouchEvents event);
             ^
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Clang warns on `OnTouchEvent()` function, which is overridden, but is
missing the `override` keyword

```
In file included from InfiniTime/src/displayapp/screens/Music.cpp:18:
InfiniTime/src/displayapp/screens/Music.h:43:14: warning: 'OnTouchEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        bool OnTouchEvent(TouchEvents event);
             ^
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #1026 from NeroBurner/fix_settings_chimes</title>
<updated>2022-03-09T20:59:30Z</updated>
<author>
<name>JF</name>
<email>JF002@users.noreply.github.com</email>
</author>
<published>2022-03-09T20:59:30Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=21da5869c5e48df666ea9d9c7698f7f69528645e'/>
<id>21da5869c5e48df666ea9d9c7698f7f69528645e</id>
<content type='text'>
Fix SettingChimes cbOption array size</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix SettingChimes cbOption array size</pre>
</div>
</content>
</entry>
<entry>
<title>Fix SettingChimes cbOption array size</title>
<updated>2022-03-08T22:12:34Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2022-03-08T22:10:06Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=f47b04ffd0ee401381f18cfedd716d492b4c7db8'/>
<id>f47b04ffd0ee401381f18cfedd716d492b4c7db8</id>
<content type='text'>
There are 3 options, but the array-size is set to 2. This leads to
memory corruption in the initialization of the SettingChimes screen when
assigning the third option object pointer.

Found in https://github.com/InfiniTimeOrg/InfiniSim/issues/11
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are 3 options, but the array-size is set to 2. This leads to
memory corruption in the initialization of the SettingChimes screen when
assigning the third option object pointer.

Found in https://github.com/InfiniTimeOrg/InfiniSim/issues/11
</pre>
</div>
</content>
</entry>
</feed>
