<feed xmlns='http://www.w3.org/2005/Atom'>
<title>infinitime.git/src/displayapp/screens/Music.h, branch edge</title>
<subtitle>Unnamed repository; edit this file 'description' to name the repository.
</subtitle>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/'/>
<entry>
<title>Music: fix warning about overridden function</title>
<updated>2022-03-13T20:58:53Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2022-03-13T20:58:53Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=0933d60b1627df18c5615c610b8e26a685901b44'/>
<id>0933d60b1627df18c5615c610b8e26a685901b44</id>
<content type='text'>
Clang warns on `OnTouchEvent()` function, which is overridden, but is
missing the `override` keyword

```
In file included from InfiniTime/src/displayapp/screens/Music.cpp:18:
InfiniTime/src/displayapp/screens/Music.h:43:14: warning: 'OnTouchEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        bool OnTouchEvent(TouchEvents event);
             ^
```
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Clang warns on `OnTouchEvent()` function, which is overridden, but is
missing the `override` keyword

```
In file included from InfiniTime/src/displayapp/screens/Music.cpp:18:
InfiniTime/src/displayapp/screens/Music.h:43:14: warning: 'OnTouchEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
        bool OnTouchEvent(TouchEvents event);
             ^
```
</pre>
</div>
</content>
</entry>
<entry>
<title>Music: initialize totalLength to have non-random data from the start</title>
<updated>2022-01-23T22:39:38Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2022-01-23T22:34:25Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=314c02194a19016d83fb71a41f6f647959b7be1e'/>
<id>314c02194a19016d83fb71a41f6f647959b7be1e</id>
<content type='text'>
In the first `Music::Refresh` call the lastLength and totalLength are
not initialized. The `lastLength` value is read first from the
musicService. Naturally in the first itereation that is changed and
`UpdateLength()` is called. There the variable `totalLength` is used as
well, but that variable isn't initialed to a sensible value yet. This
leads to sometimes the `Music.h` screen segfaulting (depending on the
random uninitialized data in the `lastLength` variable)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
In the first `Music::Refresh` call the lastLength and totalLength are
not initialized. The `lastLength` value is read first from the
musicService. Naturally in the first itereation that is changed and
`UpdateLength()` is called. There the variable `totalLength` is used as
well, but that variable isn't initialed to a sensible value yet. This
leads to sometimes the `Music.h` screen segfaulting (depending on the
random uninitialized data in the `lastLength` variable)
</pre>
</div>
</content>
</entry>
<entry>
<title>Update includes to to be relative to src directory</title>
<updated>2021-11-15T21:02:49Z</updated>
<author>
<name>Reinhold Gschweicher</name>
<email>pyro4hell@gmail.com</email>
</author>
<published>2021-10-13T20:08:35Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=ac7b2da611fa5ef4cc989a9feb027f66c0ebfc6c'/>
<id>ac7b2da611fa5ef4cc989a9feb027f66c0ebfc6c</id>
<content type='text'>
Don't use relative imports like `../foo.h` as those depend on the
relative position of both files. Rather than that use imports relative
to the `src` directory, which explicitly is part of the include
directories.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Don't use relative imports like `../foo.h` as those depend on the
relative position of both files. Rather than that use imports relative
to the `src` directory, which explicitly is part of the include
directories.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'develop' into refresh_rework</title>
<updated>2021-08-15T10:35:15Z</updated>
<author>
<name>Riku Isokoski</name>
<email>riksu9000@gmail.com</email>
</author>
<published>2021-08-15T10:35:15Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=3cef05b7451fca3b2bbd5e96714c0262d52ac4d1'/>
<id>3cef05b7451fca3b2bbd5e96714c0262d52ac4d1</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Ui update</title>
<updated>2021-08-15T09:19:47Z</updated>
<author>
<name>Riku Isokoski</name>
<email>riksu9000@gmail.com</email>
</author>
<published>2021-06-13T09:47:12Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=e0d01411d7124abc5ad099360057ba683287c428'/>
<id>e0d01411d7124abc5ad099360057ba683287c428</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Refresh rework</title>
<updated>2021-07-19T13:26:12Z</updated>
<author>
<name>Riku Isokoski</name>
<email>riksu9000@gmail.com</email>
</author>
<published>2021-07-19T13:26:12Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=97c761a5c74994ea1d9bef9c14e6e24afb9b4be2'/>
<id>97c761a5c74994ea1d9bef9c14e6e24afb9b4be2</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Changed access modified indentation</title>
<updated>2021-04-24T09:00:45Z</updated>
<author>
<name>Avamander</name>
<email>avamander@gmail.com</email>
</author>
<published>2021-04-24T09:00:45Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=69898545193a82f7d72c9f47c9d9de36167b157b'/>
<id>69898545193a82f7d72c9f47c9d9de36167b157b</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Reformatted all the files according to clang-format style</title>
<updated>2021-04-24T08:39:53Z</updated>
<author>
<name>Avamander</name>
<email>avamander@gmail.com</email>
</author>
<published>2021-04-18T17:28:14Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=40d45d923b033363ff1304b47eac238dd4495a57'/>
<id>40d45d923b033363ff1304b47eac238dd4495a57</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #259 from JF002/fix-music-app2</title>
<updated>2021-04-09T18:44:02Z</updated>
<author>
<name>JF002</name>
<email>JF002@users.noreply.github.com</email>
</author>
<published>2021-04-09T18:44:02Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=9096d1db4c6be9f4a2cc8af99a994c219f25108c'/>
<id>9096d1db4c6be9f4a2cc8af99a994c219f25108c</id>
<content type='text'>
Fix music app</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix music app</pre>
</div>
</content>
</entry>
<entry>
<title>Fix music app :</title>
<updated>2021-04-04T15:19:41Z</updated>
<author>
<name>Jean-François Milants</name>
<email>jf@codingfield.com</email>
</author>
<published>2021-04-04T15:19:41Z</published>
<link rel='alternate' type='text/html' href='http://cgit.tidal.blue/infinitime.git/commit/?id=f8b9a7c06081df68b34defd8df4a5ae39b390237'/>
<id>f8b9a7c06081df68b34defd8df4a5ae39b390237</id>
<content type='text'>
 - Enable LVGL animation (and disable groups, which were not used), and set the speed.
 - Fix disc animation and progress display by initializing lastIncrement at 0 (a random value will be used otherwise, in release build)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 - Enable LVGL animation (and disable groups, which were not used), and set the speed.
 - Fix disc animation and progress display by initializing lastIncrement at 0 (a random value will be used otherwise, in release build)
</pre>
</div>
</content>
</entry>
</feed>
